From commits-return-9612-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Jun 1 06:00:50 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E60EC1804BB for ; Mon, 1 Jun 2020 08:00:49 +0200 (CEST) Received: (qmail 9699 invoked by uid 500); 1 Jun 2020 06:00:49 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 9690 invoked by uid 99); 1 Jun 2020 06:00:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jun 2020 06:00:48 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_fynmanoj_removed_a_comment_on_pull_req?= =?utf-8?q?uest_=23948=3A_replace_iText_with_openPDF_=5BFINERACT-965=5D?= Message-ID: <159099124866.10999.449404918069716924.asfpy@gitbox.apache.org> Date: Mon, 01 Jun 2020 06:00:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: fynmanoj removed a comment on pull request #948: URL: https://github.com/apache/fineract/pull/948#issuecomment-636497502 :) On Sun, 31 May, 2020, 22:13 Michael Vorburger ⛑️, wrote: > *@vorburger* commented on this pull request. > ------------------------------ > > In > fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java > : > > > @@ -140,7 +140,8 @@ public Response retrieveImage(@PathParam("entity") final String entityName, @Pat > > imageDataURISuffix = ContentRepositoryUtils.ImageDataURIsuffix.PNG.getValue(); > > } > > > > - final String clientImageAsBase64Text = imageDataURISuffix + Base64.encodeBytes(imageData.getContentOfSize(maxWidth, maxHeight)); > > + byte[] resizedImage = imageData.getContentOfSize(maxWidth, maxHeight); > > + final String clientImageAsBase64Text = imageDataURISuffix + Base64.getEncoder().encode(resizedImage); > > > @fynmanoj no you're absolutely right of > course, it was (very) wrong - Thank You very much for spotting that! > > PS: It's totally OK to help code review and tell me "this is wrong!" more > strongly than your very polite "Are you sure about" 😄 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or > unsubscribe > > . > -- Disclaimer: Privileged & confidential information is contained in this message (including all attachments). If you are not an intended recipient of this message, please destroy this message immediately and kindly notify the sender by reply e-mail. Any unauthorised use or dissemination of this message in any manner whatsoever, in whole or in part, is strictly prohibited. This e-mail, including all attachments hereto, (i) is for discussion purposes only and shall not be deemed or construed to be a professional opinion unless expressly stated otherwise, and (ii) is not intended, written or sent to be used, and cannot and shall not be used, for any unlawful purpose. This communication, including any attachments, may not be free of viruses, interceptions or interference, and may not be compatible with your systems. You should carry out your own virus checks before opening any attachment to this e-mail. The sender of this e-mail and  *Fynarfin Tech Private Limited* shall not be liable for any damage that you may sustain as a result of viruses, incompleteness of this message, a delay in receipt of this message or computer problems experienced.  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org