fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] ptuomola opened a new pull request #1049: FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob
Date Sat, 13 Jun 2020 03:58:27 GMT

ptuomola opened a new pull request #1049:

   ## Description
   Fixed two bugs that were triggered by scheduler integration tests: 
   - Invalid query in SavingsAccountCharge (missing parameters)
   - Lazy loading not working for m_savings_account.group_id due to transaction boundary
   Also changed triggering of jobs to use executeAndAwaitJob() and fixed logging for exceptions
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   - [ ] Commit message starts with the issue number from
Ex: FINERACT-646 Pockets API.
   - [ ] Coding conventions at
have been followed.
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm
has been updated with details of any API changes.
   - [ ] Integration tests have been created/updated for verifying the changes made.
   - [ ] All Integrations tests are passing with the new commits.
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   Our guidelines for code reviews is at

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message