fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1079: Added and Enforced AvoidHidingCauseException Checkstyle (FINERACT-942)
Date Sat, 27 Jun 2020 14:58:49 GMT

thesmallstar commented on a change in pull request #1079:
URL: https://github.com/apache/fineract/pull/1079#discussion_r446534931



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/exception/EmailConfigurationNotFoundException.java
##########
@@ -28,4 +29,9 @@
     public EmailConfigurationNotFoundException(final String name) {
         super("error.msg.email.configuration.name.not.found", "Email configuration with name
" + name + " does not exist", name);

Review comment:
       Nope, we cannot change the original implementation. If the cause of the exception is
the exception itself, we need this constructor to be used. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message