fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1079: Added and Enforced AvoidHidingCauseException Checkstyle (FINERACT-942)
Date Fri, 26 Jun 2020 16:13:11 GMT

thesmallstar commented on pull request #1079:
URL: https://github.com/apache/fineract/pull/1079#issuecomment-650264163


   @vorburger  @xurror  can you please review this?
   I have some points:- 
   1. I used suppresswarning at two places( I thought the current approach is correct ).
   2. Some Predefined exceptions were of the form: 
             throw new PredefinedException(x.messege()); // x was lost exception
   this is converted to
             throw new PredefinedException(x); //x is throwable at the exception accepts it,
   This was a a lot of manual work btw :P 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message