fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1006: FINERACT-822 add MissingCasesInEnumSwitch
Date Tue, 23 Jun 2020 18:05:18 GMT

vorburger commented on a change in pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#discussion_r444411453



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -4501,7 +4505,9 @@ private LocalDate getMaxDateLimitForNewRepayment(final PeriodFrequencyType
perio
             break;
             case INVALID:
             break;
-            default:

Review comment:
       But then should we be logging error in other places below, or do like here? isn't it
inconsistent how is now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message