fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] xurror commented on a change in pull request #928: [WIP] Migrate ORM from OpenJPA to EclipseLink(Fineract 849)
Date Tue, 23 Jun 2020 13:07:18 GMT

xurror commented on a change in pull request #928:

File path: fineract-provider/config/checkstyle/spotbugs-exclude.xml
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements. See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership. The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License. You may obtain a copy of the License at
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+    <Match>

Review comment:
       Unfortunately EclipseLink weaving makes some changes to classes which violate this
particular spotbugs rule. Given that I can't fix this without disabling weaving/enhancement,
I thought it best to just ignore.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message