fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #1099: FINERACT-822 Enforce UndefinedEquals check
Date Tue, 23 Jun 2020 11:27:49 GMT

percyashu commented on a change in pull request #1099:
URL: https://github.com/apache/fineract/pull/1099#discussion_r444152233



##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -100,8 +100,9 @@ public boolean equals(Object obj) {
         }
         TrialBalance other = (TrialBalance) obj;
         return Objects.equals(other.officeId, officeId) && Objects.equals(other.glAccountId,
glAccountId)
-                && Objects.equals(other.amount, amount) && Objects.equals(other.entryDate,
entryDate)
-                && Objects.equals(other.transactionDate, transactionDate) &&
Objects.equals(other.closingBalance, closingBalance);
+                && Objects.equals(other.amount, amount) && other.entryDate.compareTo(entryDate)
== 0 ? Boolean.TRUE
+                        : Boolean.FALSE && other.transactionDate.compareTo(transactionDate)
== 0 ? Boolean.TRUE

Review comment:
       This is just like a Java If statement where other.entryDate.compareTo(entryDate) ==
0 is the condition, the first value Boolean.TRUE is return if the condition is true and the
second value Boolean.FALSE if it is false. Could have used an If statement but this is shorter.
See [this](https://www.baeldung.com/java-ternary-operator) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message