fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #1019: [WIP] FINERACT-821 Added and Enforced HideUtilityClassConstructor checkstyle
Date Tue, 23 Jun 2020 09:56:23 GMT

thesmallstar commented on a change in pull request #1019:
URL: https://github.com/apache/fineract/pull/1019#discussion_r444105628



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/client/ClientEntityWorkbookPopulatorTest.java
##########
@@ -60,9 +60,8 @@ public void setup(){
     @Test
     public void testClientEntityWorkbookPopulate() throws IOException {
         //in order to populate helper sheets
-        StaffHelper staffHelper=new StaffHelper();
         requestSpec.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON);
-        Integer outcome_staff_creation =staffHelper.createStaff(requestSpec,responseSpec);
+        Integer outcome_staff_creation =StaffHelper.createStaff(requestSpec,responseSpec);

Review comment:
       Nope, it is all manual clean-up. Just that my IDE(vscode) does give a suggestion for
this while writing code which makes it easier to spot. 
   In this case, since I am removing the object I have "no other option" that making it static
it throws out an error. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message