fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #1069: FINERACT-835: Upgrade Swagger and automatically generate the JSON spec
Date Sat, 20 Jun 2020 17:26:47 GMT

ptuomola commented on a change in pull request #1069:
URL: https://github.com/apache/fineract/pull/1069#discussion_r443146505



##########
File path: fineract-provider/src/main/resources/static/swagger-ui/index.html
##########
@@ -0,0 +1,60 @@
+<!-- HTML for static distribution bundle build -->

Review comment:
       @vorburger The swagger-ui-dist does include an index.html, but that one points to petstore's
JSON spec by default. The Swagger UI Docker image etc allows overriding the default JSON spec
location with variables, but the WebJar package doesn't seem to. Hence I needed to override
the default /swagger-ui/index.html to allow us to control the JSON spec that gets loaded by
default (i.e. currently response.json, in the future fineract.json)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message