fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nnatarajan commented on a change in pull request #1090: FINERACT-853 Use find-sec-bugs SpotBugs plugin to detect SQL injectio…
Date Sat, 20 Jun 2020 13:57:17 GMT

nnatarajan commented on a change in pull request #1090:
URL: https://github.com/apache/fineract/pull/1090#discussion_r443132941



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareTenantIdentifierFilter.java
##########
@@ -97,7 +97,7 @@ public void doFilter(final ServletRequest req, final ServletResponse res,
final
 
             // allows for Cross-Origin
             // Requests (CORs) to be performed against the platform API.
-            response.setHeader("Access-Control-Allow-Origin", "*");
+            response.setHeader("Access-Control-Allow-Origin", "Fineract-Platform-TenantId");

Review comment:
       The files updated were related PR 1091. After the fact,  the same updates were requested
on the develop branch. The failing checks were independent of this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message