fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #1022: FINERACT-822 enable UnnecessaryDefaultInEnumSwitch error
Date Sat, 20 Jun 2020 10:55:40 GMT

percyashu commented on a change in pull request #1022:
URL: https://github.com/apache/fineract/pull/1022#discussion_r443121844



##########
File path: fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java
##########
@@ -87,9 +88,8 @@ public void generateClientSchedule() {
                                 run = Days.daysBetween(start, end).getDays() >= adhoc.getReportRunEvery();
                             break;
                             default:
-                                throw new IllegalStateException();
+                                throw new IllegalArgumentException();

Review comment:
       Was my mistake wasn't not suppose to change the exception will revert it. Yeah we need
it because Error prone thinks it is not necessary since all cases are specified.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message