fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1068: FINERACT-723: Fixed to use the right date in more tests
Date Wed, 17 Jun 2020 08:48:33 GMT

ptuomola commented on pull request #1068:
URL: https://github.com/apache/fineract/pull/1068#issuecomment-645243106


   @vorburger As far as I can see, DateUtils.getDateOfTenant is the "server side" version:
it assumes it can find the Tenant object from a ThreadLocal variable initialised on the server.

   
   org.apache.fineract.integrationtests.common.Utils.getLocalDateOfTenant() is a "client side"
version that is used only by the tests. It currently only returns dates based on a hardcoded
timezone of "Asia/Kolkata" which matches the default tenant set-up used in the server. 
   
   I think we'll always need a test client and a server side version of this. Of course the
latter could be made smarter by e.g. retrieving the timezone from the server. But at the same
time, given it's only used in integration tests and all the ITs use the same timezone, I'm
not sure this would add a lot of value...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message