fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1049: FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob
Date Sun, 14 Jun 2020 11:31:01 GMT

vorburger commented on a change in pull request #1049:
URL: https://github.com/apache/fineract/pull/1049#discussion_r439819898



##########
File path: fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
##########
@@ -229,7 +229,7 @@ public void applyAnnualFeeForSavings() {
                     LOG.error("Apply annual fee failed for account: {} with message {}",
savingsAccountReference.getAccountNo(), error);
                 }
             } catch (final Exception ex) {
-                // need to handle this scenario
+                LOG.error("Apply annual fee failed for account: {} with message: {}", savingsAccountReference.getAccountNo(),
ex.getMessage());
             }

Review comment:
       I see what you mean, but didn't get it initially. For "consistency", let's keep it
like you have fixed it, and deal with it if we have overflowing logs, only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message