fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #92: fix: Warning on going back in forms
Date Fri, 12 Jun 2020 08:50:36 GMT

jawidMuhammadi commented on a change in pull request #92:
URL: https://github.com/apache/fineract-cn-mobile/pull/92#discussion_r439292572



##########
File path: app/src/main/java/org/apache/fineract/ui/online/customers/createcustomer/customeractivity/CreateCustomerActivity.java
##########
@@ -204,6 +205,20 @@ public void showError(String message) {
         Toaster.show(findViewById(android.R.id.content), message);
     }
 
+    @Override
+    public void onBackPressed() {
+        new MaterialDialog.Builder()

Review comment:
       Yeah I think it is necessary because showing a dialog to the user saying that he will
lose his unsaved data even if he didn't enter any data or changed anything, kind of puts the
user in doubt and it's unnecessary, and also it is not good from UX point of view. You can
implement this by setting a `touch listener` to EditTexts and handle it using a `boolean`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message