fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1006: FINERACT-822 add MissingCasesInEnumSwitch
Date Tue, 09 Jun 2020 21:30:21 GMT

thesmallstar commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-641592588


   @vorburger @ptuomola @percyashu 
   I was researching a bit on this after reading your comments, I found a few reasons why
we should always have a default case, I am quoting from checkstyle docs.
   
   Rationale: It's usually a good idea to introduce a default case in every switch statement.
Even if the developer is sure that all currently possible cases are covered, this should be
expressed in the default branch, e.g. by using an assertion. This way the code is protected
against later changes, e.g. introduction of new types in an enumeration type.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message