fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Date Tue, 09 Jun 2020 16:36:16 GMT

percyashu commented on a change in pull request #1018:
URL: https://github.com/apache/fineract/pull/1018#discussion_r437294067



##########
File path: fineract-provider/build.gradle
##########
@@ -436,7 +436,8 @@ modernizer {
 
     ignorePackages = []
     ignoreClassNamePatterns = [
-        '.*AbstractPersistableCustom'
+        '.*AbstractPersistableCustom',
+        '.*EntityTables'

Review comment:
       Errorprone wants all fields in Enumeration to Immutable, hence Integer[] is require
to be ImmutableList<Integer> and modernizer wants all ImmutableList.of to be List.of
which Error prone doesn't consider as Immutable, hence had to add EntityTables to this list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message