fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi edited a comment on pull request #92: fix: Warning on going back in forms
Date Mon, 08 Jun 2020 08:47:57 GMT

jawidMuhammadi edited a comment on pull request #92:
URL: https://github.com/apache/fineract-cn-mobile/pull/92#issuecomment-640455723


   As I see we are creating the same dialog with the same attributes in each activity, would
you make the code a little more modular and less line of code, please? You can create a method
named something like`showBackConfirmDialog(Activity activity)` in `Utils` class bypassing
the `activity` as a parameter to call it's `onBackPressed()` method then simply you can use
that method in where you need it. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message