fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #92: fix: Warning on going back in forms
Date Mon, 08 Jun 2020 08:43:39 GMT

jawidMuhammadi commented on a change in pull request #92:
URL: https://github.com/apache/fineract-cn-mobile/pull/92#discussion_r436541283



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -311,6 +311,10 @@
     <string name="dialog_action_logout">Logout</string>
     <string name="dialog_title_confirm_deletion">Confirm deletion</string>
     <string name="dialog_title_confirm_logout">Confirm logout</string>
+    <string name="dialog_title_confirm_back">Are you sure you want to go back?</string>
+    <string name="dialog_message_confirmation_back">All unsaved changes will be lost.</string>
+    <string name="dialog_action_go_back">Go back</string>
+    <string name="dialog_action_stay">Stay here</string>

Review comment:
       I think it would be much better and simple if we name our actions as `Yes` or `Cancel`
because we are asking the user a Yes/No question (`Are you sure you want to go back?`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message