fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #92: fix: Warning on going back in forms
Date Mon, 08 Jun 2020 08:27:32 GMT

jawidMuhammadi commented on a change in pull request #92:
URL: https://github.com/apache/fineract-cn-mobile/pull/92#discussion_r436532468



##########
File path: app/src/main/java/org/apache/fineract/ui/online/customers/createcustomer/customeractivity/CreateCustomerActivity.java
##########
@@ -204,6 +205,20 @@ public void showError(String message) {
         Toaster.show(findViewById(android.R.id.content), message);
     }
 
+    @Override
+    public void onBackPressed() {
+        new MaterialDialog.Builder()

Review comment:
       It is a good feature to have in the App but you have to handle other scenarios too
like we shouldn't show this dialog if the user has not entered any data or didn't edit any
existing data which we are using the same fragments for editing and updating too.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message