fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #89: fix: Differ fake data from actual network response in LoanAccounts
Date Mon, 08 Jun 2020 06:51:14 GMT

jawidMuhammadi commented on a change in pull request #89:
URL: https://github.com/apache/fineract-cn-mobile/pull/89#discussion_r436487974



##########
File path: app/src/main/java/org/apache/fineract/data/models/loan/LoanAccount.kt
##########
@@ -19,7 +19,8 @@ data class LoanAccount(
     @SerializedName("createdOn") var createdOn: String? = null,
     @SerializedName("createdBy") var createdBy: String? = null,
     @SerializedName("lastModifiedOn") var lastModifiedOn: String? = null,
-    @SerializedName("lastModifiedBy") var lastModifiedBy: String? = null
+    @SerializedName("lastModifiedBy") var lastModifiedBy: String? = null,
+    @SerializedName("isFakeData") var isFakeData: Boolean? = false

Review comment:
       I think it is not a good idea to add attributes to a retrofit model from the client-side
and actually we can't modify it. if it is really necessary then it should be added by backend
guys first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message