fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #87: fix: Back button in different fragments in dashboard
Date Mon, 08 Jun 2020 06:24:52 GMT

jawidMuhammadi commented on a change in pull request #87:
URL: https://github.com/apache/fineract-cn-mobile/pull/87#discussion_r436478659



##########
File path: app/src/main/java/org/apache/fineract/ui/online/accounting/accounts/AccountsFragment.kt
##########
@@ -164,4 +167,13 @@ class AccountsFragment : FineractBaseFragment(), AccountContract.View,
SwipeRefr
         accountsPresenter.detachView()
     }
 
+    override fun onBackPressed(): Boolean {
+        if (searchView?.isIconified!!)

Review comment:
       `!!` causes the app to crash if the object is null, instead of this it would be much
better to s.do something like this: `searchView?.isIconified == true`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message