fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #983: FINERACT-822 Enabling ErrorProne error checks
Date Sun, 07 Jun 2020 13:13:03 GMT

vorburger commented on a change in pull request #983:
URL: https://github.com/apache/fineract/pull/983#discussion_r436361965



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
##########
@@ -200,6 +199,7 @@ public static SavingsAccountTransactionEnumData transactionType(final
SavingsAcc
                 optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
                         SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release
Amount");
                 break;
+            default:

Review comment:
       @percyashu @awasum I disagree with this, this seems wrong to me - I've raised new #997
for it.
   
   PS: I'm happy to help code review such PRs, if you would like me to.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message