fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror commented on a change in pull request #975: FINERACT-822 Adding more checks to be enabled
Date Thu, 04 Jun 2020 01:19:19 GMT

xurror commented on a change in pull request #975:
URL: https://github.com/apache/fineract/pull/975#discussion_r434939497



##########
File path: fineract-provider/build.gradle
##########
@@ -330,13 +330,32 @@ tasks.withType(JavaCompile) {
                 "UnusedNestedClass",
                 "UndefinedEquals",
                 "JdkObsolete",
-                "OperatorPrecedence"
+                "OperatorPrecedence",
+                "EmptyBlockTag",
+                "MissingSummary",
+                "MutablePublicArray",
+                "InvalidParam",
+                "ReturnFromVoid",
+                "AlmostJavadoc",
+                "PublicConstructorForAbstractClass",
+                "ProtectedMembersInFinalClass",
+                "StaticAssignmentInConstructor",
+                "UnescapedEntity",
+                "EmptyCatch",

Review comment:
       Seems this is not a valid check, maybe a typo or maybe you meant something else and
wrote something else. I can merge this once this is resolved.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message