fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #961: FINERACT-822 enable ArgumentSelectionDefectChecker warning
Date Tue, 02 Jun 2020 16:32:56 GMT

awasum commented on pull request #961:
URL: https://github.com/apache/fineract/pull/961#issuecomment-637667602


   > @vorburger I thought so too but since compiler warning are set to errors with "-Werror",
it will still fail if picked up. Nevertheless I can still move it to the error check list.
   
   Please..when responding to a comment...make sure you respond in the right section. @vorburger
gave a review feedback and its just natural for you @percyashu to respond to that feedback
just below it on same Conversation not for you to reply on a separte general comment section.
I dont know if am making sense @percyashu ? See
   ![image](https://user-images.githubusercontent.com/15528032/83545395-0a01f800-a4f7-11ea-9364-2e9447a71c2d.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message