fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #961: FINERACT-822 enable ArgumentSelectionDefectChecker warning
Date Tue, 02 Jun 2020 04:35:45 GMT

vorburger commented on a change in pull request #961:
URL: https://github.com/apache/fineract/pull/961#discussion_r433615067



##########
File path: fineract-provider/build.gradle
##########
@@ -324,7 +324,6 @@ tasks.withType(JavaCompile) {
                 "BadImport",
                 "UnusedMethod",
                 "ModifiedButNotUsed",
-                "ArgumentSelectionDefectChecker",

Review comment:
       @percyashu I see on https://errorprone.info/bugpattern/ArgumentSelectionDefectChecker
that by default this is just a Warning. Given that this seems to fix real bugs (which you
are seem to be proposing to fix in this PR? I have not looked closely at each...), should
we not configure this, and every other currently disabled check as you go along, to actually
be an Error instead of just a Warning?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message