fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] fynmanoj removed a comment on pull request #948: replace iText with openPDF [FINERACT-965]
Date Mon, 01 Jun 2020 06:00:48 GMT

fynmanoj removed a comment on pull request #948:
URL: https://github.com/apache/fineract/pull/948#issuecomment-636497502


   :)
   
   On Sun, 31 May, 2020, 22:13 Michael Vorburger ⛑️, <notifications@github.com>
   wrote:
   
   > *@vorburger* commented on this pull request.
   > ------------------------------
   >
   > In
   > fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java
   > <https://github.com/apache/fineract/pull/948#discussion_r432963841>:
   >
   > > @@ -140,7 +140,8 @@ public Response retrieveImage(@PathParam("entity") final
String entityName, @Pat
   >
   >              imageDataURISuffix = ContentRepositoryUtils.ImageDataURIsuffix.PNG.getValue();
   >
   >          }
   >
   >
   >
   > -        final String clientImageAsBase64Text = imageDataURISuffix + Base64.encodeBytes(imageData.getContentOfSize(maxWidth,
maxHeight));
   >
   > +        byte[] resizedImage = imageData.getContentOfSize(maxWidth, maxHeight);
   >
   > +        final String clientImageAsBase64Text = imageDataURISuffix + Base64.getEncoder().encode(resizedImage);
   >
   >
   > @fynmanoj <https://github.com/fynmanoj> no you're absolutely right of
   > course, it was (very) wrong - Thank You very much for spotting that!
   >
   > PS: It's totally OK to help code review and tell me "this is wrong!" more
   > strongly than your very polite "Are you sure about" 😄
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/948#discussion_r432963841>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ANQLL2SUUHFFDYOBGXKQLI3RUKCL7ANCNFSM4NNNXV4Q>
   > .
   >
   
   -- 
   Disclaimer:
   
   
   Privileged & confidential information is contained in this 
   message (including all attachments). If you are not an intended recipient 
   of this message, please destroy this message immediately and kindly notify
   
   the sender by reply e-mail. Any unauthorised use or dissemination of this 
   message in any manner whatsoever, in whole or in part, is strictly 
   prohibited. This e-mail, including all attachments hereto, (i) is for 
   discussion purposes only and shall not be deemed or construed to be a 
   professional opinion unless expressly stated otherwise, and (ii) is not 
   intended, written or sent to be used, and cannot and shall not be used, for 
   any unlawful purpose. This communication, including any attachments, may 
   not be free of viruses, interceptions or interference, and may not be 
   compatible with your systems. You should carry out your own virus checks 
   before opening any attachment to this e-mail. The sender of this e-mail and 
   
   *Fynarfin Tech Private Limited* shall not be liable for any damage that 
   you may sustain as a result of viruses, incompleteness of this message, a 
   delay in receipt of this message or computer problems experienced. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message