From commits-return-9447-archive-asf-public=cust-asf.ponee.io@fineract.apache.org  Mon May 25 07:25:52 2020
Return-Path: <commits-return-9447-archive-asf-public=cust-asf.ponee.io@fineract.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 0894618062C
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 25 May 2020 09:25:51 +0200 (CEST)
Received: (qmail 87315 invoked by uid 500); 25 May 2020 07:25:51 -0000
Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@fineract.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@fineract.apache.org>
List-Post: <mailto:commits@fineract.apache.org>
List-Id: <commits.fineract.apache.org>
Reply-To: dev@fineract.apache.org
Delivered-To: mailing list commits@fineract.apache.org
Received: (qmail 87306 invoked by uid 99); 25 May 2020 07:25:51 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 May 2020 07:25:51 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@fineract.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?=
 =?utf-8?q?l_request_=23934=3A_FINERACT-821_Added_IllegalTokenText_Checkstyl?=
 =?utf-8?q?e?=
Message-ID: <159039155099.19379.14236747748729591109.asfpy@gitbox.apache.org>
Date: Mon, 25 May 2020 07:25:50 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <fineract.934.MDExOlB1bGxSZXF1ZXN0NDIyNDkzMTkx.gitbox@gitbox.apache.org>
In-Reply-To: <fineract.934.MDExOlB1bGxSZXF1ZXN0NDIyNDkzMTkx.gitbox@gitbox.apache.org>


vorburger commented on a change in pull request #934:
URL: https://github.com/apache/fineract/pull/934#discussion_r429772914



##########
File path: fineract-provider/config/checkstyle/checkstyle.xml
##########
@@ -108,16 +113,8 @@
       
         <module name="SuppressWarningsHolder" />
         <module name="OuterTypeFilename"/>
-        <module name="IllegalTokenText">
-            <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
-            <property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
-            <property name="message" value="Avoid using corresponding octal or Unicode escape."/>
-        </module>
-        <module name="AvoidEscapedUnicodeCharacters">

Review comment:
       I've noticed that you have removed instead of moved this module.. was that intentionally? Why?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org