From commits-return-9250-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Thu May 21 07:06:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05C3E1804BB for ; Thu, 21 May 2020 09:06:38 +0200 (CEST) Received: (qmail 15918 invoked by uid 500); 21 May 2020 07:06:38 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 15909 invoked by uid 99); 21 May 2020 07:06:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2020 07:06:38 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_maektwain_commented_on_pull_request_?= =?utf-8?q?=23915=3A_FINERACT-986=3A_Update_spotbugs_to_v4=2E2=2E0?= Message-ID: <159004479831.19379.17817107990584758408.asfpy@gitbox.apache.org> Date: Thu, 21 May 2020 07:06:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: maektwain commented on pull request #915: URL: https://github.com/apache/fineract/pull/915#issuecomment-631923153 The method is updating the values, in the savings account charge now the null value was there to initialise it , might be the case that it was checking for null values somewhere else while applying the charges and then based on that computing from zero. This could be interesting to note that we can start to remove all the null values where it should be a bigDecimal as zero functionally . What are your thoughts ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org