From commits-return-9168-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Tue May 19 23:01:01 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0ADA6180638 for ; Wed, 20 May 2020 01:01:00 +0200 (CEST) Received: (qmail 76685 invoked by uid 500); 19 May 2020 23:01:00 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 76676 invoked by uid 99); 19 May 2020 23:01:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 23:01:00 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=23830=3A_FINERACT-822_enable_and_enforce_Error_Prone?= Message-ID: <158992926033.19379.16746774726933648975.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 23:01:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on a change in pull request #830: URL: https://github.com/apache/fineract/pull/830#discussion_r427647609 ########## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffTest.java ########## @@ -183,13 +185,15 @@ public void testStaffUpdate() { Assert.assertEquals(mobileNo, changes.get("mobileNo")); } + @SuppressWarnings("JUnit4TestNotRun") public void testStaffUpdateLongExternalIdError() { final HashMap map = new HashMap<>(); map.put("externalId", Utils.randomStringGenerator("EXT", 98)); StaffHelper.updateStaff(requestSpec, responseSpecForValidationError, 1, map); } Review comment: @percyashu I suppose someone just "forgot" to add `@Test` ? What I suggest you do is do add `@Test` for all these cases (instead of `@SuppressWarnings("JUnit4TestNotRun")`), and try running them. If they fail, slap an `@Ignore` on those that do fail - and then subsequently but in a later separate PR see if you can fix them (or someone else can do that, as part of future work to review all ignored tests). Sounds like a plan? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org