From commits-return-9129-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Tue May 19 07:21:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 294F7180638 for ; Tue, 19 May 2020 09:21:55 +0200 (CEST) Received: (qmail 85339 invoked by uid 500); 19 May 2020 07:21:54 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 85329 invoked by uid 99); 19 May 2020 07:21:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 07:21:54 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=23906=3A_=5BWIP=5D_FINERACT-942_Remove_use_of_printStackTrace_an?= =?utf-8?q?d_added_checkstyle?= Message-ID: <158987291396.19379.690749113100207206.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 07:21:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-630635248 @thesmallstar no in non-test it depends.. definitely never printStackTrace() but either catch(SomeException e) { LOG.error("explanation", e) -OR- (re, "chain") throw NewEception("Details", e) - but typically never BOTH log and re-throw but only either-or. HTH? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org