From commits-return-9118-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon May 18 07:18:47 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4423E18062B for ; Mon, 18 May 2020 09:18:47 +0200 (CEST) Received: (qmail 3514 invoked by uid 500); 18 May 2020 07:18:46 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 3505 invoked by uid 99); 18 May 2020 07:18:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2020 07:18:46 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_xurror_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=23906=3A_=5BWIP=5D_FINERACT-942_Remove_use_of_printStackT?= =?utf-8?q?race_and_added_checkstyle?= Message-ID: <158978632646.19379.14084073790763440723.asfpy@gitbox.apache.org> Date: Mon, 18 May 2020 07:18:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: xurror commented on a change in pull request #906: URL: https://github.com/apache/fineract/pull/906#discussion_r426406214 ########## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountingScenarioIntegrationTest.java ########## @@ -587,11 +587,8 @@ public void checkPeriodicAccrualAccountingFlow() { this.journalEntryHelper.checkJournalEntryForAssetAccount(assetAccount, this.EXPECTED_DISBURSAL_DATE, assetAccountInitialEntry); final String jobName = "Add Accrual Transactions"; - try { - this.schedulerJobHelper.executeJob(jobName); - } catch (InterruptedException e) { - e.printStackTrace(); Review comment: I suggest you using a logger but maybe @vorburger or @awasum, @ptuomola or anyone else would have a different opinion as far as this is concerned. It's more a convention to use here, whether checked or unchecked exceptions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org