From commits-return-9092-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun May 17 06:55:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 523E5180643 for ; Sun, 17 May 2020 08:55:09 +0200 (CEST) Received: (qmail 29563 invoked by uid 500); 17 May 2020 06:55:08 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 29554 invoked by uid 99); 17 May 2020 06:55:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 May 2020 06:55:08 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_awasum_commented_on_pull_request_=2383?= =?utf-8?q?2=3A_remove_=28useless=29_SenderTest_+_mockrunner-jms/nekohtml_?= =?utf-8?q?=28FINERACT-938=29?= Message-ID: <158969850839.19379.16322222854277281108.asfpy@gitbox.apache.org> Date: Sun, 17 May 2020 06:55:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: awasum commented on pull request #832: URL: https://github.com/apache/fineract/pull/832#issuecomment-629752568 Please, merge it now. I just wanted someone familiar with the notification feature to look at it. But we can't keep waiting for that forever. So merge this ASAP. Thanks and sorry for holding this that's precious time but it was for a good reason. On Sun, May 17, 2020, 01:44 Michael Vorburger ⛑️ wrote: > I've just rebased this and resolved conflicts. @awasum > given that we haven't heard back from @Anh3h > within 1 week, and that @ptuomola > expresses support for *"great if we can get > rid of Mockrunner with its awful dependency tree"* and my explanations > about the value of this test, would you have any strong objections to > merging this? It's a simplification of our dependencies which we will only > be grateful for in the future, at the loss of a IMHO useless test. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or > unsubscribe > > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org