From commits-return-9025-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sat May 16 09:44:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA461180626 for ; Sat, 16 May 2020 11:44:03 +0200 (CEST) Received: (qmail 47508 invoked by uid 500); 16 May 2020 09:44:03 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 47499 invoked by uid 99); 16 May 2020 09:44:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 May 2020 09:44:03 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=23887=3A_FINERACT-830=3A_Configuring_Dockerfile_to_use?= =?utf-8?q?_Google_Distroless_base_image?= Message-ID: <158962224287.19379.15424164515246822556.asfpy@gitbox.apache.org> Date: Sat, 16 May 2020 09:44:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on a change in pull request #887: URL: https://github.com/apache/fineract/pull/887#discussion_r426137973 ########## File path: Dockerfile ########## @@ -32,30 +32,11 @@ COPY *LICENSE* fineract/ COPY *NOTICE* fineract/ WORKDIR fineract -# RUN find . -RUN ./gradlew clean -x rat -x test war +RUN ./gradlew clean -x rat -x test bootJar # ========================================= -FROM bitnami/tomcat:9.0 as fineract +FROM gcr.io/distroless/java:11 as fineract -USER root -RUN apt-get update -qq && apt-get install -y wget - -COPY --from=builder /fineract/build/libs/fineract-provider.war /opt/bitnami/tomcat/webapps - -RUN keytool -genkey -keyalg RSA -alias tomcat -keystore /opt/bitnami/tomcat/tomcat.keystore -keypass xyz123 -storepass xyz123 -noprompt -dname "CN=Fineract, OU=Fineract, O=Fineract, L=Unknown, ST=Unknown, C=Unknown" -COPY ./docker/server.xml /opt/bitnami/tomcat/conf -RUN chmod 664 /opt/bitnami/tomcat/conf/server.xml - -WORKDIR /opt/bitnami/tomcat/lib -# org.drizzle.jdbc.DrizzleDriver is used by default for both the all tenants and demo tenant DB DataSource -RUN wget https://repo1.maven.org/maven2/org/drizzle/jdbc/drizzle-jdbc/1.4/drizzle-jdbc-1.4.jar - -# https://issues.apache.org/jira/browse/LEGAL-462 -# https://issues.apache.org/jira/browse/FINERACT-762 -# We include an alternative JDBC driver (which is faster, but not allowed to be default in Apache distribution) -# allowing implementations to switch the driver used by changing start-up parameters (for both tenants and each tenant DB) -# The commented out lines in the docker-compose.yml illustrate how to do this. -# To be sure that this instead of Drizlle is used, comment out wget above. -RUN wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.19/mysql-connector-java-8.0.19.jar Review comment: @ptuomola due to FINERACT-980 I have just created FINERACT-982 for future discussion on this front, if you want to chime in there. But in the very short term, to get this PR in, IMHO we should still keep this as is? Unless you have any better ideas... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org