From commits-return-8979-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Fri May 15 17:57:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 125D3180608 for ; Fri, 15 May 2020 19:57:50 +0200 (CEST) Received: (qmail 34356 invoked by uid 500); 15 May 2020 17:57:50 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 34347 invoked by uid 99); 15 May 2020 17:57:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 May 2020 17:57:50 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=23885=3A_Email_sending_fixed_and_improvements_=28See_Fineract-69?= =?utf-8?q?9=29?= Message-ID: <158956547032.19379.5461683764318601318.asfpy@gitbox.apache.org> Date: Fri, 15 May 2020 17:57:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on pull request #885: URL: https://github.com/apache/fineract/pull/885#issuecomment-629398448 @nemux anything we can do to help you wrap this up? PS: If you think adding a test for this is too much to ask for this PR, I also don't really mind at all if we merge this without a test (once you made it pass the build, of course; and provided feedback the other more minor points raised above), and then create another JIRA and you perhaps contribute the test in a later PR. If Email sending is currently broken (it is?), then I guess fixing it even without a test yet is still better than having it broken! :smile: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org