From commits-return-8880-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun May 10 13:39:48 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC5D11804BB for ; Sun, 10 May 2020 15:39:47 +0200 (CEST) Received: (qmail 96021 invoked by uid 500); 10 May 2020 13:39:47 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 96012 invoked by uid 99); 10 May 2020 13:39:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2020 13:39:47 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=23857=3A_=5BWIP=5D_MySQL_v8=28FINERACT-897=29?= Message-ID: <158911798704.4590.14359211436531963030.asfpy@gitbox.apache.org> Date: Sun, 10 May 2020 13:39:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on pull request #857: URL: https://github.com/apache/fineract/pull/857#issuecomment-626329669 > @awasum, @vorburger, @ptuomola is it for you? I would prefer to see the Flyway upgrade raised a separate PR with ref. to FINERACT-810. Make FINERACT-810 a blocker for FINERACT-897 if that is the case (I'm assuming that you have found that it is). Let us then clarify by updating both the title of FINERACT-897 and the commit comment in this PR to more precisely express what exactly this is, and isn't... I think what we have concluded in FINERACT-897 is that this now actually is NOT (anymore) a "Upgrade to mysql v8", but... "make SQL and code work on both MySQL 5.7 as well as more recent versions such as v8" - kind of wording? As for reviewing the (massive, wow, how did you do that, hats off!) SQL diff in this PR, I'm not the most qualified - I'm hoping other parties interested in MySQL would chime in to review this better than I could. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org