fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nnatarajan opened a new pull request #949: NN_FINERACT-933 Suggestion to fix ArrayIndexOutOfBoundsException
Date Thu, 28 May 2020 23:46:23 GMT

nnatarajan opened a new pull request #949:
URL: https://github.com/apache/fineract/pull/949


   ## Description
   It appears that the exception may have been caused by the formatting of dashes in which
the code expects a dash, but the input doesn't contain dashes or the possibility that the
spreadsheet has an empty cell. If so, then there would be a similar or the same error for
the logic directly below it.
   
   FYI -- Due to recent changes in the file, the exception moved down a few lines from 149
to 154.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message