fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] jamesidw opened a new pull request #822: FINERACT-930 re-use excel styles so that the 4k row limit isn't excee…
Date Tue, 05 May 2020 13:52:56 GMT

jamesidw opened a new pull request #822:
URL: https://github.com/apache/fineract/pull/822


   ## Description
   When doing a bulk import that contains more than 4000 entries, the import stalls and doesn't
complete. Excel doesn't support more than 4000 styles in a work book yet the current code
creates a new style every time we mark a record in the output report as successful or failed.
Only two styles are actually needed.
   
   This proposes that the styles are stored in extra [hidden] sheets and referenced when requesting
for a new style. If the style already exists, use that instead of generating a new one.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message