fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola opened a new pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider
Date Mon, 04 May 2020 12:44:10 GMT

ptuomola opened a new pull request #819:
URL: https://github.com/apache/fineract/pull/819


   ## Description
   Configured Spring Boot to serve /static and /public directories from the classpath, and
moved apiDocs to /static directory so that it will be served. Removed existing serving of
'/apps/**' from cwd as a) that did not seem to be used and b) could be a potential security
risk. 
   
   TODO: Below checklist needs to be updated with the correct location of api-docs - need
to find where that is stored. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [X] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [X] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [X] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [X] Integration tests have been created/updated for verifying the changes made.
   
   - [X] All Integrations tests are passing with the new commits.
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message