fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #942: FINERACT-1008-flyway-migration-fix
Date Fri, 29 May 2020 04:50:13 GMT

ptuomola commented on pull request #942:
URL: https://github.com/apache/fineract/pull/942#issuecomment-635757103


   @fynmanoj @vorburger Looks good to me - a very nice simple solution. Unfortunately I wasn't
able to test this as I don't have a database in the right state - but the code looks correct
to me. 
   
   I suppose with hindsight we could have used this approach also for renaming the schema_version
table to the new Flyway naming convention, as we are recreating the table anyway... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message