fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on a change in pull request #830: FINERACT-822 enable and enforce Error Prone
Date Thu, 28 May 2020 16:33:13 GMT

awasum commented on a change in pull request #830:
URL: https://github.com/apache/fineract/pull/830#discussion_r431970882



##########
File path: fineract-provider/build.gradle
##########
@@ -278,6 +280,88 @@ configurations {
 tasks.withType(JavaCompile) {
     options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast","-Werror"] // TODO FINERACT-959
(gradually) enable -Xlint:all (see "javac -help -X")
     options.deprecation = true
+    options.errorprone {
+        disableWarningsInGeneratedCode = true
+        //Todo Remove necessary checks from this list
+        disable("UnusedVariable",
+                "VariableNameSameAsType",
+                "InconsistentCapitalization",
+                "UnnecessaryParentheses",
+                "ClassCanBeStatic",
+                "MissingCasesInEnumSwitch",
+                "CompareToZero",
+                "OperatorPrecedence",
+                "MixedMutabilityReturnType",
+                "SameNameButDifferent",
+                "EqualsGetClass",
+                "ReferenceEquality",
+                "StringSplitter",
+                "MissingOverride",
+                "BigDecimalEquals",
+                "ImmutableEnumChecker",
+                "EqualsUnsafeCast",
+                "AssertEqualsArgumentOrderChecker",
+                "BoxedPrimitiveEquality",
+                "BadImport",
+                "UnusedMethod",
+                "ModifiedButNotUsed",
+                "ArgumentSelectionDefectChecker",
+                "JodaPlusMinusLong",
+                "TypeParameterUnusedInFormals",
+                "DoubleBraceInitialization",
+                "UnusedNestedClass",
+                "UndefinedEquals",
+                "JdkObsolete",
+                "OperatorPrecedence",
+                "NarrowingCompoundAssignment"
+        )
+        //TODO gradually enable these checks
+        error(  "DefaultCharset",

Review comment:
       if I understand you correctly, you want to chop this up into multiple PRs by enabling/uncommenting
one or a few rules at a time and fixing them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message