fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #830: FINERACT-822 enable and enforce Error Prone
Date Thu, 28 May 2020 16:27:02 GMT

awasum commented on pull request #830:
URL: https://github.com/apache/fineract/pull/830#issuecomment-635454264


   > some initial review feedback.. hope I'm not "too harsh" ? 
   > 
   > @awasum perhaps we could alternative reviewing this one - see my feedback, and next
round you check if @percyashu has taken what I'm raising into account, and I'll only re-check
it after you LGTM it, would that work for you?
   > 
   > /Cc @thesmallstar FYI given that you also work on code quality, perhaps this review
feedback interests you.
   
   Sounds like a good plan.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message