fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on a change in pull request #830: FINERACT-822 enable and enforce Error Prone
Date Wed, 27 May 2020 06:33:56 GMT

awasum commented on a change in pull request #830:
URL: https://github.com/apache/fineract/pull/830#discussion_r430886565



##########
File path: fineract-provider/build.gradle
##########
@@ -278,6 +280,86 @@ configurations {
 tasks.withType(JavaCompile) {
     options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast","-Werror"] // TODO FINERACT-959
(gradually) enable -Xlint:all (see "javac -help -X")
     options.deprecation = true
+    options.errorprone {
+        disableWarningsInGeneratedCode = true
+        //Todo Remove necessary checks from this list
+        disable("UnusedVariable",

Review comment:
       I see that you have added these so you can enable them and fix gradually rather than
fixing the errors at once? Make sure you look at the issues rules you are disabling so that
we dont miss catching some critical problems in the system.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message