fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #813: add (Quartz's) LoggingTriggerHistoryPlugin (re. FINERACT-922)
Date Wed, 27 May 2020 03:47:22 GMT

ptuomola commented on pull request #813:
URL: https://github.com/apache/fineract/pull/813#issuecomment-634209934


   > Is this something you can handle in a follow up PR? @ptuomola Or Is this critical
to the usefulness of this PR?
   
   Well... this is a one liner PR to introduce logging for triggers. I'm suggesting another
oneliner change that should achieve exactly the same thing but make it easy to turn on/off,
so allowing this change to comply with our logging policy. 
   
   So of course we can merge this PR and then someone else can raise another PR to remove
the line added here and add another line instead. Or we can just change this PR to use the
other line straightaway :-). Either is naturally OK with me, so will let @vorburger decide
how he'd like to handle this...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message