fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #934: FINERACT-821 Added IllegalTokenText Checkstyle
Date Mon, 25 May 2020 07:25:50 GMT

vorburger commented on a change in pull request #934:
URL: https://github.com/apache/fineract/pull/934#discussion_r429772914



##########
File path: fineract-provider/config/checkstyle/checkstyle.xml
##########
@@ -108,16 +113,8 @@
       
         <module name="SuppressWarningsHolder" />
         <module name="OuterTypeFilename"/>
-        <module name="IllegalTokenText">
-            <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
-            <property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
-            <property name="message" value="Avoid using corresponding octal or Unicode
escape."/>
-        </module>
-        <module name="AvoidEscapedUnicodeCharacters">

Review comment:
       I've noticed that you have removed instead of moved this module.. was that intentionally?
Why?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message