fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #813: add (Quartz's) LoggingTriggerHistoryPlugin (re. FINERACT-922)
Date Sun, 24 May 2020 19:29:49 GMT

awasum commented on pull request #813:
URL: https://github.com/apache/fineract/pull/813#issuecomment-633282901


   > Looking at the source code, this plugin logs at loglevel INFO. Given the logging guidelines,
do we want to therefore enable "permanently" i.e. including non-test configurations?
   > 
   > An option could be to add this to a property file so you can then comment the property
in / out when testing - but without needing to recompile:
   > 
   > org.quartz.plugin.triggHistory.class =
   > org.quartz.plugins.history.LoggingTriggerHistoryPlugin
   
   Is this something you can handle in a follow up PR? @ptuomola  Or Is this critical to the
usefulness of this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message