fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #927: FINERACT-804 unpin OkHTTP version number
Date Sat, 23 May 2020 06:46:36 GMT

vorburger commented on a change in pull request #927:
URL: https://github.com/apache/fineract/pull/927#discussion_r429520506



##########
File path: fineract-provider/build.gradle
##########
@@ -81,8 +81,8 @@ dependencyManagement {
         dependency 'org.springframework.security.oauth:spring-security-oauth2:2.3.6.RELEASE'
         dependency "org.apache.openjpa:openjpa:3.1.1" // when upgrading, also change OpenJPA
version repeated above in buildscript!
         dependency 'com.squareup.retrofit:retrofit:1.9.0'
-        dependency 'com.squareup.okhttp:okhttp:2.0.0'
-        dependency 'com.squareup.okhttp:okhttp-urlconnection:2.0.0'
+        dependency 'com.squareup.okhttp:okhttp:+'
+        dependency 'com.squareup.okhttp:okhttp-urlconnection:+'

Review comment:
       As per comment in line 79 of this file, we actually do NOT want to use '+' versions
- because they're "unpredictable". Instead, manually fix the latest one currently available
here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message