fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #924: FINERACT-609 TopUp
Date Fri, 22 May 2020 18:30:23 GMT

percyashu commented on a change in pull request #924:
URL: https://github.com/apache/fineract/pull/924#discussion_r429396101



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java
##########
@@ -171,6 +172,12 @@ public AccountSummaryCollectionData retrieveGroupAccountDetails(final
Long group
         return this.jdbcTemplate.query(sql, rm, new Object[]{groupId , glimAccount});
     }
 
+    @Override
+    public Collection<LoanAccountSummaryData> retrieveGroupActiveLoanAccountSummary(final
Long groupId) {
+        final String loanWhereClause = " where l.group_id = ? and l.loan_status_id = 300
";

Review comment:
       From 
   
   > (since you check if client ID is not null in the service method), it might introduce
bugs in the future when someone tries to reuse this method. I would suggest returning only
loans of type 3.
   
   I removed the conditional statement to check if client ID is null from LoanReadPlatformServiceImpl




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message