fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] maektwain commented on a change in pull request #925: FINERACT-997
Date Fri, 22 May 2020 18:27:08 GMT

maektwain commented on a change in pull request #925:
URL: https://github.com/apache/fineract/pull/925#discussion_r429394705



##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/ProductToGLAccountMappingRepository.java
##########
@@ -30,8 +30,9 @@
     ProductToGLAccountMapping findByProductIdAndProductTypeAndFinancialAccountTypeAndPaymentTypeId(Long
productId, int productType,
             int financialAccountType, Long paymentType);
 
-    ProductToGLAccountMapping findByProductIdAndProductTypeAndFinancialAccountTypeAndChargeId(Long
productId, int productType,
-            int financialAccountType, Long chargeId);
+    @Query("select mapping from ProductToGLAccountMapping mapping where mapping.productId=
:productId and mapping.productType= :productType and mapping.financialAccountType= :financialAccountType
and mapping.charge.id= :chargeId")
+    ProductToGLAccountMapping findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId(@Param("productId")
Long productId, @Param("productType") int productType,
+            @Param("financialAccountType") int financialAccountType, @Param("chargeId") Long
ChargeId);

Review comment:
       Fields Types are different and usage is also different if you look here 
   
   File is AccountingProcessorHelper.java
   
   ``` java
   if (accountMappingTypeId == CashAccountsForLoan.INCOME_FROM_FEES.getValue()
                   || accountMappingTypeId == CashAccountsForLoan.INCOME_FROM_PENALTIES.getValue())
{
               final ProductToGLAccountMapping chargeSpecificIncomeAccountMapping = this.accountMappingRepository
                       .findByProductIdAndProductTypeAndFinancialAccountTypeAndChargeId(loanProductId,
PortfolioProductType.LOAN.getValue(),
                               accountMappingTypeId, chargeId);
               if (chargeSpecificIncomeAccountMapping != null) {
                   accountMapping = chargeSpecificIncomeAccountMapping;
               }
           }
   ```
   It uses the chargeId 
   
   and perviously it gets passed here 
   
   ```
   final GLAccount chargeSpecificAccount = getLinkedGLAccountForSavingsCharges(savingsProductId,
accountTypeToBeCredited.getValue(),
                   chargePaymentDTO.getChargeId());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message