fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #925: FINERACT-997
Date Fri, 22 May 2020 17:40:52 GMT

vorburger commented on a change in pull request #925:
URL: https://github.com/apache/fineract/pull/925#discussion_r429375219



##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/ProductToGLAccountMappingRepository.java
##########
@@ -30,8 +30,9 @@
     ProductToGLAccountMapping findByProductIdAndProductTypeAndFinancialAccountTypeAndPaymentTypeId(Long
productId, int productType,
             int financialAccountType, Long paymentType);
 
-    ProductToGLAccountMapping findByProductIdAndProductTypeAndFinancialAccountTypeAndChargeId(Long
productId, int productType,
-            int financialAccountType, Long chargeId);
+    @Query("select mapping from ProductToGLAccountMapping mapping where mapping.productId=
:productId and mapping.productType= :productType and mapping.financialAccountType= :financialAccountType
and mapping.charge.id= :chargeId")
+    ProductToGLAccountMapping findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId(@Param("productId")
Long productId, @Param("productType") int productType,
+            @Param("financialAccountType") int financialAccountType, @Param("chargeId") Long
ChargeId);

Review comment:
       @maektwain I'd like to better understand what problem this fixes how... At first glance,
to me this looks like we are just writing an explicit `@Query` for what Spring Data otherwise
automagically internally generates with from its `findBy` syntax... can you help me understand
what I'm missing? What Query does the current version generate, and what is wrong with it
which this explicit version fixes? How is the auto-generated query wrong?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message