fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vorbur...@apache.org
Subject [fineract] branch develop updated: FINERACT-821 Added PackageName checkstyle
Date Fri, 22 May 2020 07:31:24 GMT
This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 014c6bb  FINERACT-821 Added PackageName checkstyle
014c6bb is described below

commit 014c6bba40abda1a1b92c5da99e62253102eaa81
Author: thesmallstar <manthan.surkar@gmail.com>
AuthorDate: Fri May 22 08:22:37 2020 +0530

    FINERACT-821 Added PackageName checkstyle
---
 fineract-provider/config/checkstyle/checkstyle.xml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml
index 5188da4..51ae8c9 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -72,6 +72,11 @@
             <property name="message" value="Line contains printStacktrace()."/>
             <property name="ignoreComments" value="false" />
         </module>
+          <module name="PackageName">
+            <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]*)*$"/>
+            <message key="name.invalidPattern"
+             value="Package name ''{0}'' must match pattern ''{1}''."/>
+        </module>
 <!-- TODO Enable many more checks (go about this one by one, step by step, raise separate
PRs fixing and then enforcing):
 
         <module name="HiddenField">
@@ -153,11 +158,7 @@
             <property name="tokens" value="COMMA"/>
             <property name="option" value="EOL"/>
         </module>
-        <module name="PackageName">
-            <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]*)*$"/>
-            <message key="name.invalidPattern"
-             value="Package name ''{0}'' must match pattern ''{1}''."/>
-        </module>
+      
         <module name="TypeName">
             <message key="name.invalidPattern"
              value="Type name ''{0}'' must match pattern ''{1}''."/>


Mime
View raw message